Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the Fetcher by Container and refactor media type sniffing #373

Merged
merged 38 commits into from
Aug 22, 2023

Conversation

mickael-menu
Copy link
Member

@mickael-menu mickael-menu commented Aug 1, 2023

Changelog

Changed

Shared

  • Publication.localizedTitle is nullable, as we cannot guarantee that all publication sources offer a title.
  • The MediaType sniffing helpers are deprecated in favor of MediaTypeRetriever (for media type and file extension hints and raw content) and AssetRetriever (for URLs).

Streamer

  • The Fetcher interface was deprecated in favor of the Container one in readium-shared.

Notes

  • Href API was revamped and now supports file:// schemes.
  • Removed Asset.name, Container.name and Resource.name.

@mickael-menu mickael-menu marked this pull request as ready for review August 2, 2023 13:35
@mickael-menu mickael-menu requested a review from qnga August 2, 2023 13:35
@mickael-menu mickael-menu changed the title Remove the Fetcher in favor of Container/Resource Replace the Fetcher by Container and refactor media type sniffing Aug 22, 2023
@qnga qnga merged commit 1570e80 into v3 Aug 22, 2023
3 checks passed
@qnga qnga deleted the remove-fetcher branch August 22, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants