Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cleanup #372

Merged
merged 12 commits into from
Aug 2, 2023
Merged

More cleanup #372

merged 12 commits into from
Aug 2, 2023

Conversation

stevenzeck
Copy link
Contributor

@stevenzeck stevenzeck commented Jul 31, 2023 •
edited
Loading

  1. Remove code that isn't being used. Note: I don't ever see setScrollingCacheEnabled in the Webview being used since USE_CACHE is always false and mScrollingCacheEnabled does nothing else.
  2. Use BundleCompat and IntentCompat to retrieve parceables depending on Android version.
  3. Use ServiceCompat for stopForeground
  4. Suppress deprecations of files that will be deprecated by the toolkit itself soon

qnga
qnga approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mickael-menu
Copy link
Member

Thank you @stevenzeck 👍

@mickael-menu mickael-menu merged commit a9e8b0d into readium:v3 Aug 2, 2023
3 checks passed
@mickael-menu mickael-menu deleted the more-cleanup branch August 2, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickael-menu mickael-menu mickael-menu left review comments

@qnga qnga qnga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenzeck @mickael-menu @qnga