fix: The OperationNode will repeatedly change status between appearing and disappearing. #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and disappearing.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case,when I use the
Tabscomponent ofantd, I have found the OperationNode will repeatedly change status between appearing and disappearing when the tabs component's with is almost equal to the sum of the width of all tab items.Then I found one of the parameters
visibleTabContentValueof hook functionuseVisibleRangewill repeatedly change. I just try to figure it out what happen.At last, I've found that the
needScrollvalue's judgemental condition maybe not correct.(the value oft+aistabContentSizeValue + addSizeValue). We can find these two number is almost equal so that they are equal. And then the needScroll is false.So I think the
needScrollcan be just only comparing the part of integer is enough.BTW, I just only test my case without other complicated use. If there are other problems, welcome to point them out