Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change types into React.Key of tabs props #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lantianyou
Copy link

IMO, the key type will make more sense as React.Key. Since I have not read the codebase throughly, maybe the key is string for a reason. If so, feel free to close this PR.

@vercel
Copy link

vercel bot commented Mar 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
tabs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 9:06AM (UTC)

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #653 (9862844) into master (81f004d) will not change coverage.
The diff coverage is n/a.

❗ Current head 9862844 differs from pull request most recent head 533ebed. Consider uploading reports for the commit 533ebed to get more accurate results

@@           Coverage Diff           @@
##           master     #653   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          17       17           
  Lines         622      622           
  Branches      165      165           
=======================================
  Hits          610      610           
  Misses         12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant