Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation - Avoid Conflicts With Other Packages #1955

Merged
merged 7 commits into from
Sep 20, 2024

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Sep 19, 2024

This is a simple tweak that ensures that LivewireTable localisations are specific to the tables.

The majority of use cases will see no issues.

If you have over-ridden terms locally (e.g. "All Columns", then you will need to revise this.

Some imminent updates will help to address this.

Until released - this should be considered as under development!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.18%. Comparing base (0c8ec45) to head (ed2ffdb).
Report is 98 commits behind head on development.

Files with missing lines Patch % Lines
src/Views/Traits/Columns/IsSortable.php 80.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1955      +/-   ##
=================================================
+ Coverage          87.30%   88.18%   +0.88%     
- Complexity          1672     1845     +173     
=================================================
  Files                150      172      +22     
  Lines               3891     4250     +359     
=================================================
+ Hits                3397     3748     +351     
- Misses               494      502       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 256b12d into rappasoft:development Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant