-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE] ucxx v0.40 #289
Merged
Merged
[RELEASE] ucxx v0.40 #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch-0.39 into branch-0.40
Also fix up the isort configuration to get more correct results. Contributes to rapidsai/build-planning#33 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - James Lamb (https://github.com/jameslamb) - Vyas Ramasubramani (https://github.com/vyasr) URL: #252
Improve compile-time error reports by marking appropriate C++ constructors and getters with `[[nodiscard]]`. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #255
Increase maximum UCX runtime pin to support UCX up to `v1.17.x`, but still build against `v1.15.0` until we gain confidence with newer UCX. Additionally disable protov2 by default as CUDA async/managed memory is not yet supported and leads to poor performance. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) - James Lamb (https://github.com/jameslamb) URL: #240
Partially addresses issue: rapidsai/build-planning#82 As UCXX no longer needs NumPy during the build, make sure the Conda packages do not use it when building UCXX. Authors: - https://github.com/jakirkham - Mike Sarahan (https://github.com/msarahan) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Mike Sarahan (https://github.com/msarahan) URL: #256
Rather than building `libucxx_python.so` in the `libucxx` build, and transferring it to the `ucxx` package, build it in the `ucxx` build. Nothing other than the Python wheel is currently using `ucxx::python`, so stop exporting it and installing the headers as well. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - James Lamb (https://github.com/jameslamb) URL: #257
…rsion (#258) Contributes to rapidsai/build-planning#58. `scikit-build-core==0.10.0` was released today (https://github.com/scikit-build/scikit-build-core/releases/tag/v0.10.0), and wheel-building configurations across RAPIDS are incompatible with it. This proposes upgrading to that version and fixing configuration here in a way that: * is compatible with that new `scikit-build-core` version * takes advantage of the forward-compatibility mechanism (`minimum-version`) that `scikit-build-core` provides, to reduce the risk of needing to do this again in the future Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham URL: #258
This PR updates pre-commit hooks to the latest versions that are supported without causing style check errors. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - James Lamb (https://github.com/jameslamb) URL: #263
This PR improves `update-version.sh` by clarifying suffix handling and RAPIDS version handling. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #259
Contributes to rapidsai/build-planning#33 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Bradley Dice (https://github.com/bdice) URL: #260
Since the --rapids-version argument will change from one release to the next, use a block style instead of a flow style to make merge conflicts less likely. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #266
CI may eventually fail due to unsuccessful attempts to clone the Distributed repository. This change ensures multiple attempts are made to clone it before failing. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #269
`*.pxd` files were mistakenly removed in #260. Resume installing them in the ucxx wheel. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #270
This PR removes the NumPy<2 pin. This is desirable for RAPIDS projects that do not have a strong numpy/cupy dependency. Not doing any math, they don't run into subtle issues, but the pin was still necessary briefly before NumPy 2 was initially released. (Other RAPIDS projects rely heavily on CuPy/NumPy and need the soon to be released 13.3.0 to function properly, e.g. due to promotion related changes in NumPy.) Authors: - Sebastian Berg (https://github.com/seberg) Approvers: - Mike Sarahan (https://github.com/msarahan) - James Lamb (https://github.com/jameslamb) - https://github.com/jakirkham URL: #271
Contributes to rapidsai/build-planning#88 Finishes the work of dropping Python 3.9 support. This project stopped building / testing against Python 3.9 as of rapidsai/shared-workflows#235. This PR updates configuration and docs to reflect that. ## Notes for Reviewers ### How I tested this Checked that there were no remaining uses like this: ```shell git grep -E '3\.9' git grep '39' git grep 'py39' ``` And similar for variations on Python 3.8 (to catch things that were missed the last time this was done). Authors: - James Lamb (https://github.com/jameslamb) Approvers: - https://github.com/jakirkham - Bradley Dice (https://github.com/bdice) URL: #272
This PR updates rapidsai/pre-commit-hooks to the version 0.4.0. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - James Lamb (https://github.com/jameslamb) URL: #275
Due to licensing restrictions, suggest users install Miniforge3 from now on. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #274
Contributes to rapidsai/build-planning#40 This PR adds support for Python 3.12. ## Notes for Reviewers This is part of ongoing work to add Python 3.12 support across RAPIDS. It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213. A follow-up PR will revert back to pointing at the `branch-24.10` branch of `shared-workflows` once all RAPIDS repos have added Python 3.12 support. ### This will fail until all dependencies have been updates to Python 3.12 CI here is expected to fail until all of this project's upstream dependencies support Python 3.12. This can be merged whenever all CI jobs are passing. Authors: - James Lamb (https://github.com/jameslamb) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Bradley Dice (https://github.com/bdice) - Peter Andreas Entschev (https://github.com/pentschev) URL: #276
Update version error message to match the minimum support UCX version and provide instructions to check where UCX is being loaded from. Ported from rapidsai/ucx-py#1069 Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #277
* Update fmt (to 11.0.2) and spdlog (to 1.14.1). * fix rapids-cmake redirect * use rmm CI artifacts * use cudf CI artifacts * fix cudf CI downloads * mirror changes [skip ci] * kick off a build * typo * fix wheel script * move unused things to comments * filepath * fix paths * run all CI * workflow branch * remove testing-only changes [skip ci] * remove CI-only scripts [skip ci]
raydouglass
requested review from
KyleFromNVIDIA
and removed request for
a team
September 27, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❄️ Code freeze for
branch-24.10
and v24.10 releaseWhat does this mean?
Only critical/hotfix level issues should be merged into
branch-24.10
until release (merging of this PR).What is the purpose of this PR?
branch-24.10
intomain
for the release