hack to pass endpoint through from pr.yaml to shared workflows

rapidsai · Oct 17, 2024 · 356f804 · 356f804
1 parent f61b00f
commit 356f804
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -35,6 +35,9 @@ jobs:
         id: timestamp
         run:
             echo "START_TIME=$(date +%s.%N)" >> ${GITHUB_OUTPUT}
+      - name: Echo endpoint to make it available to shared workflows
+        run: |
+          echo "endpoint=${OTEL_EXPORTER_OTLP_ENDPOINT}" >> ${GITHUB_OUTPUTS}
       - name: Write certificate files for mTLS
         run: |
           mkdir -p /tmp/certs
@@ -53,7 +56,6 @@ jobs:
       - name: Start root span
         uses: rapidsai/shared-actions/telemetry-create-span@add-telemetry
         with:
-            service: ${{env.OTEL_SERVICE_NAME}}
             name: "root span"
             traceparent: ${{steps.telemetry-setup.outputs.traceparent}}
             start_time: ${{steps.timestamp.outputs.START_TIME}}
@@ -81,7 +83,7 @@ jobs:
     needs: telemetry-setup
     uses: rapidsai/shared-workflows/.github/workflows/changed-files.yaml@add-telemetry
     with:
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
       files_yaml: |
         test_cpp:
@@ -105,7 +107,7 @@ jobs:
     uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@add-telemetry
     with:
       enable_check_generated_files: false
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
       ignored_pr_jobs: "final_span_update"
   conda-cpp-build:
@@ -116,7 +118,7 @@ jobs:
     uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@add-telemetry
     with:
       build_type: pull-request
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   conda-cpp-tests:
     needs: [conda-cpp-build, changed-files, telemetry-setup]
@@ -125,7 +127,7 @@ jobs:
     if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_cpp
     with:
       build_type: pull-request
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   conda-python-build:
     needs:
@@ -135,7 +137,7 @@ jobs:
     uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@add-telemetry
     with:
       build_type: pull-request
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   conda-python-tests:
     needs: [conda-python-build, changed-files, telemetry-setup]
@@ -144,7 +146,7 @@ jobs:
     if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python
     with:
       build_type: pull-request
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   docs-build:
     needs:
@@ -158,7 +160,7 @@ jobs:
       arch: "amd64"
       container_image: "rapidsai/ci-conda:latest"
       run_script: "ci/build_docs.sh"
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   wheel-build-cpp:
     needs:
@@ -170,7 +172,7 @@ jobs:
       matrix_filter: group_by([.ARCH, (.CUDA_VER|split(".")|map(tonumber)|.[0])]) | map(max_by(.PY_VER|split(".")|map(tonumber)))
       build_type: pull-request
       script: ci/build_wheel_cpp.sh
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   wheel-build-python:
     needs:
@@ -181,7 +183,7 @@ jobs:
     with:
       build_type: pull-request
       script: ci/build_wheel_python.sh
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   wheel-tests:
     needs: [wheel-build-python, changed-files, telemetry-setup]
@@ -191,7 +193,7 @@ jobs:
     with:
       build_type: pull-request
       script: ci/test_wheel.sh
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
   devcontainer:
     secrets: inherit
@@ -201,7 +203,7 @@ jobs:
     with:
       arch: '["amd64"]'
       cuda: '["12.5"]'
-      default_endpoint: "${{github.env.OTEL_EXPORTER_OTLP_ENDPOINT}}"
+      default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
       traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
       build_command: |
         sccache -z;
@@ -232,4 +234,4 @@ jobs:
         with:
             traceparent: ${{needs.telemetry-setup.outputs.traceparent}}
             start_time: ${{needs.telemetry-setup.outputs.start_time}}
-            end_time: ${{steps.timestamp.outputs.FINAL_TIME}}
+            end_time: ${{steps.timestamp.outputs.FINAL_TIME}}