Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sccache, print sccache stats in builds #112

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 29, 2024

Description

Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • printing sccache stats to CI logs
  • updating to the latest rapids-dependency-file-generator (v1.16.0) and rapidsai/pre-commit-hooks (v0.4.0)
  • always explicitly specifying python in calls to rapids-upload-wheels-to-s3

While doing that, I also noticed this project wasn't using sccache. This PR proposes using sccache to drive compilation, to speed up builds a bit.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] print sccache stats in builds WIP: [DO NOT MERGE] use sccache, print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] use sccache, print sccache stats in builds use sccache, print sccache stats in builds Oct 29, 2024
@jameslamb jameslamb requested a review from bdice October 29, 2024 18:59
@jameslamb jameslamb marked this pull request as ready for review October 29, 2024 18:59
@jameslamb jameslamb requested review from a team as code owners October 29, 2024 18:59
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s very little compilation for this package, so it’s fine if we have no sccache. Either way, I am approving this for uniformity’s sake.

@jameslamb
Copy link
Member Author

Alright yeah, thank you. I'll merge this as-is.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 666375a into rapidsai:main Oct 29, 2024
39 checks passed
@jameslamb jameslamb deleted the print-sccache-stats branch October 29, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants