Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider .conda files in rapids-extract-conda-files #122

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 15, 2024

Related to rapidsai/shared-workflows#250

Also part of rapidsai/build-planning#98

Starting with rapidsai/ci-imgs#176, RAPIDS projects are producing .conda-formatted conda packages. That breaks the conda-cpp-checks CI workflow because the rapids-extract-conda-files tool here only considers .tar.bz2 files.

rapidsai/ci-imgs#197 adds the cph tool to all the CI images.

This PR uses it to extract the contents of files.

Notes for Reviewers

How I tested this

Put the content of rapids-extract-conda-files as of this PR at the working directory I ran docker run from.

Then ran the following, with RAPIDS_* values set from a PR where we saw the failure: rapidsai/raft#2470

docker run \
    --rm \
    -v $(pwd):/opt/work \
    -w /opt/work \
    --network host \
    --env RAPIDS_BUILD_TYPE=pull-request \
    --env RAPIDS_SHA=51cdd7d0e08ee7facb10432b7a0899312d678faf\
    --env RAPIDS_PR_NUMBER=2470 \
    --env RAPIDS_REPOSITORY=rapidsai/raft \
    --env RAPIDS_REF_NAME=pull-request/2470 \
    -it rapidsai/ci-wheel:latest \
    bash

CPP_DIR=$(rapids-download-conda-from-s3 cpp)
EXTRACTED_DIR=$(./rapids-extract-conda-files "${CPP_DIR}")

Saw that succeed, and the package be extracted to exactly where we want it to be:

ls "${EXTRACTED_DIR}"
# bin  include  info  lib  test

ls "${EXTRACTED_DIR}/lib"
# cmake  libraft.a  libraft.so

@jameslamb jameslamb added the non-breaking Introduces a non-breaking change label Oct 15, 2024
@jameslamb jameslamb requested a review from bdice October 15, 2024 21:56
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants