Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build wheels without build isolation, print sccache stats in builds #792

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Oct 15, 2024

Description

Contributes to rapidsai/build-planning#108
Contributes to rapidsai/build-planning#111

Proposes some small packaging/CI changes, matching similar changes being made across RAPIDS.

  • removes the use of build isolation in wheel builds
  • printing sccache stats to CI logs
  • reducing pip's verbosity in wheel building scripts
  • using the RAPIDS conventions py_build_{project} and py_rapids_build_{project} in dependencies.yaml
  • updating to the latest rapids-dependency-file-generator (v1.16.0)

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change do not merge labels Oct 15, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation WIP: [DO NOT MERGE] print sccache stats in builds Oct 23, 2024
@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] print sccache stats in builds WIP: [DO NOT MERGE] build wheels without build isolation, print sccache stats in builds Oct 23, 2024
@jakirkham
Copy link
Member

One thing we would like to do is move to scikit-build-core: #645

Though that hasn't happened yet

We discussed some package restructuring ( #763 ), which would unblock scikit-build-core

Imagine things get a lot simpler to manage here if we are able to make those changes

@jameslamb
Copy link
Member Author

Imagine things get a lot simpler to manage here if we are able to make those changes

"things" in general, definitely. Those look like good changes that should be made in this project.

But to be clear... the work described in those issues you linked wouldn't materially change the way this PR looks. For example, cuspatial projects already use scikit-build-core and have the wheels split into C++ vs. Python, and the changeset in that repo for this effort was pretty similar: rapidsai/cuspatial#1473

@jameslamb jameslamb changed the title WIP: [DO NOT MERGE] build wheels without build isolation, print sccache stats in builds build wheels without build isolation, print sccache stats in builds Oct 23, 2024
@jameslamb jameslamb marked this pull request as ready for review October 23, 2024 19:29
@jameslamb jameslamb requested review from a team as code owners October 23, 2024 19:29
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 89d7c2b into rapidsai:branch-24.12 Oct 28, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants