Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…alSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs.
Description
Added a function with name lookupDomainNamesForSIDs in src\main\java\com\rapid7\client\dcerpc\mslsad\LocalSecurityAuthorityService.java to get a list of domain names for the corresponding SIDs. This function is similar to the function which is used to get translated names for the corresponding SIDs.
Motivation and Context
Getting a username along with its domain name was required while working on a project. But the current library code do not offer this functionality. Extending the LocalSecurityAuthorityService.java and adding a function was a solution but it would be easier if smbj-rpc offered this functionality.
How Has This Been Tested?
This has been tested by using single as well as multiple SIDs as arguments. The response is as expected i.e. an array of domain names.
Types of changes
Checklist: