Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random test failure introduced by #4385 #4416

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

randombit
Copy link
Owner

Fixes #4415

@coveralls
Copy link

coveralls commented Oct 27, 2024

Coverage Status

coverage: 91.078% (+0.001%) from 91.077%
when pulling 914e969 on jack/fix-4415
into dc326ed on master.

Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit uneasy about the recursion, frankly. Alternative would be wrapping this into for(size_t attempts = 10; attempts > 0; --attempts) {} with a continue instead of the recursive invocation and a "graceful" abort in case something goes south. But I'm guessing this is unlikely enough so that we don't end in long chain of recursive calls.

@randombit
Copy link
Owner Author

Another simple response would be if we find ourselves with x == 0 return a completely random scalar instead.

@randombit randombit merged commit 07699f2 into master Oct 29, 2024
38 checks passed
@randombit randombit deleted the jack/fix-4415 branch October 29, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird ecc_randomized failure
3 participants