Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all Kyber r3 TLS ciphersuites with intent to remove in 3.7.0 #4407

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

randombit
Copy link
Owner

The TLS ecosystem is rapidly moving to the standarized variant of Kyber (FIPS 203 ML-KEM), which we also already support. Supporting the pre-standard/experimental r3 ciphersuites through the entire Botan3 lifetime is not reasonable.

GH #4403

@randombit randombit requested a review from reneme October 24, 2024 11:05
@randombit randombit force-pushed the jack/deprecate-tls-kyber-r3 branch 2 times, most recently from 9f1c1b6 to 382248b Compare October 24, 2024 11:39
@randombit randombit added this to the Botan 3.6.1 milestone Oct 24, 2024
doc/api_ref/tls.rst Outdated Show resolved Hide resolved
src/lib/tls/tls_algos.h Outdated Show resolved Hide resolved
src/lib/tls/tls_algos.h Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Oct 24, 2024

Coverage Status

coverage: 91.137% (-0.001%) from 91.138%
when pulling b0cf1cb on jack/deprecate-tls-kyber-r3
into 932a3dc on master.

@reneme
Copy link
Collaborator

reneme commented Oct 24, 2024

CI failure is relevant:

build/include/public/botan/tls_algos.h:226:68: error: ‘constexpr bool Botan::TLS::Group_Params::is_pure_kyber() const’ is deprecated: Kyber r3 TLS support will be removed completely in Botan 3.7.0 (early 2025) see https://github.com/randombit/botan/issues/4403 [-Werror=deprecated-declarations]
    226 |       constexpr bool is_post_quantum() const { return is_pure_kyber() || is_pure_frodokem() || is_pqc_hybrid(); }

See: #4407 (comment)

@randombit randombit force-pushed the jack/deprecate-tls-kyber-r3 branch 2 times, most recently from 3aeba34 to b0cf1cb Compare October 25, 2024 09:05
The TLS ecosystem is rapidly moving to the standarized variant of
Kyber (FIPS 203 ML-KEM), which we also already support. Supporting the
pre-standard/experimental r3 ciphersuites through the entire Botan3
lifetime is not reasonable.

GH #4403
@randombit randombit merged commit 0a16e2c into master Oct 25, 2024
38 checks passed
@randombit randombit deleted the jack/deprecate-tls-kyber-r3 branch October 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants