Update Limbo test suite and fix relevant bugs #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neither of these seem critical so I'm pushing this to 3.7.0 milestone. |
reneme
approved these changes
Oct 24, 2024
| @@ -156,7 +156,7 @@ if type -p "apt-get"; then | |||
|
|
|||
| elif [ "$TARGET" = "limbo" ]; then | |||
| sudo apt-get -qq install python3-dateutil | |||
| wget -nv https://raw.githubusercontent.com/C2SP/x509-limbo/bd88042508ccfde351b2fee293aebda8971fbebb/limbo.json -O "${SCRIPT_LOCATION}/../../../limbo.json" | |||
| wget -nv https://raw.githubusercontent.com/C2SP/x509-limbo/f98aa03f45d108ae4e1bc5a61ec4bd0b8d137559/limbo.json -O "${SCRIPT_LOCATION}/../../../limbo.json" | |||
There was a problem hiding this comment.
Perhaps this could live in a future central repo config (see #4390)
We did not reject an empty EKU extension, when this is invalid. We did not check subject alternative name DNS entries at all Co-authored-by: René Meusel <[email protected]>
randombit
force-pushed
the
jack/update-limbo
branch
from
47a0b01
to
5d3f3c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not reject an empty EKU extension, when this is invalid.
We did not check subject alternative name DNS entries at all