Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve notification and documentation of deprecated features #4050

Merged
merged 1 commit into from
May 11, 2024

Conversation

randombit
Copy link
Owner

In #3910 we introduced a nice way of marking specific modules as deprecated. However this change did not set the lifecycles of any specific modules.

Additionally, officially deprecate the TPM support which is pretty obsolete and these days not well tested. (GH #3877)

@randombit randombit requested a review from reneme May 11, 2024 16:49
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Dilithium AES may also go on this list. Same argument as with Kyber 90s.

@coveralls
Copy link

coveralls commented May 11, 2024

Coverage Status

coverage: 92.005% (-0.001%) from 92.006%
when pulling 9000137 on jack/mark-modules-as-deprecated
into 7606d70 on master.

@randombit randombit force-pushed the jack/mark-modules-as-deprecated branch 2 times, most recently from 0be3dd2 to dd5283c Compare May 11, 2024 20:59
@randombit randombit changed the title Mark deprecated modules as such Improve notification and documentation of deprecated features May 11, 2024
@randombit randombit force-pushed the jack/mark-modules-as-deprecated branch from dd5283c to 9000137 Compare May 11, 2024 21:14
In #3910 we introduced a nice way of marking specific modules as
deprecated. However this change did not set the lifecycles of any
specific modules.

Additionally, officially deprecate the TPM support which is pretty
obsolete and these days not well tested. (GH #3877)

Mark various headers and classes that are entirely deprecated as such
to provide some additional compile time warning for users.
@randombit randombit merged commit f7e4e93 into master May 11, 2024
43 checks passed
@randombit randombit deleted the jack/mark-modules-as-deprecated branch May 11, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants