[Select] Select scroll speed addition #3090
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct up and down button components
Saikedo
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
…ers accidentally being passed to a div via spread operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following props to
SelectScrollUpButtonPropsandSelectScrollDownButtonPropsto be able to control the scroll speed when hovering or clicking on those buttons.Props added
I made the decision to supply two separate props because the functionality and the use case might be very different. On web when hovering over the buttons, in some scenarios scroll is too fast so we might put a value of
hoverScrollFactor={0.3}for example to slow it down. At the same time on mobile we might want to increase how much the list scrolls on press so we will settouchScrollFactor={2}for example.Tested on web with various browsers as well as on Android and iOS real devices.