Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency to @radix-ui/react-portal #2966

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

walkerburgin
Copy link
Contributor

Description

@radix-ui/react-portal imports from packages/react/portal/src/Portal.tsx, but does not declare a dependency on @radix-ui/react-use-layout-effect in its package.json.

@vladmoroz vladmoroz merged commit 97071a4 into radix-ui:main Jun 21, 2024
5 checks passed
@walkerburgin
Copy link
Contributor Author

Thank you!

@vladmoroz
Copy link
Collaborator

@walkerburgin appreciate the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants