[Menu] Don’t scroll menus in response to hover #2451
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitgrelard
approved these changes
Mar 6, 2024
By default, when a menu item is focused, browsers will scroll it into view. Sometimes even into the centre of the view. This is good when using a keyboard, because the focused item is automatically visible, but when it was focused in response to mouse movement, it has the effect of moving the item out from underneath the pointer. Fixes radix-ui#1566
benoitgrelard
force-pushed
the
menu-item-scrolls-on-hover
branch
from
aad5c17
to
0173093
Compare
|
Can we merge this? :) |
|
@benoitgrelard @andy-hook i see this has been approved. we've hit this issue at my workplace too. any plans to merge it? |
|
Any plans to merge this? |
vladmoroz
approved these changes
Jun 11, 2024
|
Thanks!! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By default, when a menu item is focused, browsers will scroll it into view. Sometimes even into the centre of the view. This is good when using a keyboard, because the focused item is automatically visible, but when it was focused in response to mouse movement, it has the effect of moving the item out from underneath the pointer.
Fixes #1566