[Tabs] Add partial unit tests #2035
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silversonicaxel
requested review from
benoitgrelard and
andy-hook
as code owners
chaance
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
|
Sorry no one got back to you on this! I'm going to close this for now. Philosophically I don't think we should test implementation details, so I think this is better handled in our UI tests. |
|
ah, ok, fine by me, but, why not? |
|
Because implementation details may change and are not relevant to our end users. Whether or not we fire a click event or a series of other events under the hood is an implementation detail. Our UI tests can better simulate what an actual user does, which is limited in a virtual DOM environment unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added partial unit tests reagrding the Tabs component, related to issue #2034