Adds composePreventableEvent #1880
Open
+383
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrutchTheClutch
requested review from
benoitgrelard and
andy-hook
as code owners
|
@CrutchTheClutch I'm sorry no one got back to you on this. Are you still interested in seeing this one across the finish line? If so we'd need to resolve conflicts. Totally understand if not, just let me know and I'll put this on my todo list. |
|
@chaance For sure! No worries at all, I should be able to take a look at this again early next week |
CrutchTheClutch
force-pushed
the
compose-preventable-event
branch
from
2f9e21c
to
cff0617
Compare
CrutchTheClutch
requested review from
StephenHaney,
vladmoroz,
lucasmotta,
hadihallak and
chaance
as code owners
|
@chaance I believe this gets us back up to date with the current changes. I also went ahead and updated Form and Menubar since they were not components when I originally made this pull request. I'm a little unfamiliar with the codebase as it's been a while since I last looked at this, but the changes should be good to go now. I have also gone ahead and confirmed I can build locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed #905 and I had a similar need for a utility like this.
checkForDefaultPreventedapi by splittingcomposeEventHandlersinto two separate functions (composeEventHandlers&composePreventableEventHandlers).composeEventHandlerswith the newcomposePreventableEventHandlers.checkForDefaultPreventedwas false with the reworkedcomposeEventHandlersfunction.closes #905