fix: Select should not crash if getItems returns empty array (#2623)

Co-authored-by: Chance Strickland <[email protected]>
radix-ui · Aug 10, 2024 · 5105a22 · 5105a22
1 parent 7aea268
commit 5105a22
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.yarn/versions/cccc0adb.yml b/.yarn/versions/cccc0adb.yml
@@ -0,0 +1,5 @@
+releases:
+  "@radix-ui/react-select": patch
+
+declined:
+  - primitives
diff --git a/packages/react/select/src/Select.tsx b/packages/react/select/src/Select.tsx
@@ -859,7 +859,7 @@ const SelectItemAlignedPosition = React.forwardRef<
       const willAlignWithoutTopOverflow = contentTopToItemMiddle <= topEdgeToTriggerMiddle;
 
       if (willAlignWithoutTopOverflow) {
-        const isLastItem = selectedItem === items[items.length - 1].ref.current;
+        const isLastItem = items.length > 0 && selectedItem === items[items.length - 1].ref.current;
         contentWrapper.style.bottom = 0 + 'px';
         const viewportOffsetBottom =
           content.clientHeight - viewport.offsetTop - viewport.offsetHeight;
@@ -874,7 +874,7 @@ const SelectItemAlignedPosition = React.forwardRef<
         const height = contentTopToItemMiddle + clampedTriggerMiddleToBottomEdge;
         contentWrapper.style.height = height + 'px';
       } else {
-        const isFirstItem = selectedItem === items[0].ref.current;
+        const isFirstItem = items.length > 0 && selectedItem === items[0].ref.current;
         contentWrapper.style.top = 0 + 'px';
         const clampedTopEdgeToTriggerMiddle = Math.max(
           topEdgeToTriggerMiddle,