Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayName to icons #125

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add displayName to icons #125

wants to merge 3 commits into from

Conversation

penx
Copy link

@penx penx commented Feb 28, 2022

Fixes #124 (not tested)


PR checklist:

  • Figma: icon shapes use “Scale” constraint
  • Figma: icon components are sorted Z-A in the file
  • Figma: icon components are built with a single union or compound shape when possible
  • Figma: library changes are published
  • SVG: icons render correctly in a browser
  • SVG: icons are exported with width="15" height="15" viewBox="0 0 15 15"
  • SVG: no icons are exported with stroke
  • SVG: no icons are exported with clip-path
  • SVG: no icons exceed 5 KB
  • Website is up to date
  • Sketch file is up to date
  • IconJar file is up to date
    • Icon names in the IconJar library are correct
    • Version in the IconJar library description is correct

@vercel
Copy link

vercel bot commented Feb 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/modulz/radix-icons/Fh79rRTfyNQ96VVF7EtrXrFiu1jL
✅ Preview: https://radix-icons-git-fork-penx-patch-1.modulz-deploys.com

@LoganDark
Copy link

What happened to this PR? Any chance it could be merged?

@penx penx marked this pull request as ready for review May 18, 2024 09:43
@penx
Copy link
Author

penx commented May 18, 2024

@LoganDark I’d forgotten I’d done this! Have taken it out of draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add displayName to icons
2 participants