New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add displayName to icons #124

Open

penx opened this issue Feb 28, 2022 · 0 comments · May be fixed by #125

penx commented Feb 28, 2022

Please could you add displayName to the generated React icons?

You do this already in Radix Primitives, e.g.

https://github.com/radix-ui/primitives/blob/4ee9d362fcd5e32edbce9f43f1d41f1bf1a015c1/packages/react/accessible-icon/src/AccessibleIcon.tsx#L28

This will help to ensure the name of the icon/component appears in developer tools and documentation generators.

penx added a commit to penx/icons that referenced this issue


          Add displayName to icons

e71fc2d

Fixes radix-ui#124 (not tested)

penx linked a pull request

that will close this issue

Add displayName to icons #125

Open

14 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment