[POC] Adam-mini without explicit collectives #459
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Jul 15, 2024
ghstack-source-id: 337e89d5d973a3dd0152488277df0a3708569040 Pull Request resolved: #459
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Jul 15, 2024
ghstack-source-id: d1eefb8356e73277448174549890f4edf18f9baa Pull Request resolved: #459
awgu
commented
Jul 15, 2024
| @@ -381,7 +389,10 @@ def loss_fn(pred, labels): | |||
| # Non-PP forward / backward | |||
| with loss_parallel_ctx(): | |||
| pred = model(input_ids) | |||
| loss = loss_fn(pred, labels) | |||
| if job_config.training.compile: | |||
There was a problem hiding this comment.
Unrelated changes that help speedup training
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Jul 15, 2024
ghstack-source-id: 3c879755de47c737f8e93a614710c27f5f3e268c Pull Request resolved: #459
tianyu-l
force-pushed
the
gh/awgu/7/base
branch
from
3406987
to
baad09c
Compare
tianyu-l
force-pushed
the
gh/awgu/7/head
branch
from
7706290
to
16de427
Compare
tianyu-l
pushed a commit
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: 3c879755de47c737f8e93a614710c27f5f3e268c Pull Request resolved: #459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):