Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directors implementation #868

Open
wants to merge 1 commit into
base: community
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions 13/pajdekPL/directors.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import csv
from collections import defaultdict, namedtuple

MOVIE_DATA = '../movie_metadata.csv'
NUM_TOP_DIRECTORS = 20
MIN_MOVIES = 4
MIN_YEAR = 1960

Movie = namedtuple('Movie', 'title year score')


def movie_data_generator():
with open(MOVIE_DATA) as file:
movie_data = csv.DictReader(file)
for record in movie_data:
yield record


def get_movies_by_director():
'''Extracts all movies from csv and stores them in a dictionary
where keys are directors, and values is a list of movies (named tuples)'''
directors_movies = defaultdict(list)
movie_data = movie_data_generator
for record in movie_data():
if record['title_year'] and int(record['title_year']) >= MIN_YEAR:
directors_movies[record['director_name']].append(Movie(title=record['movie_title'],
year=int(record['title_year']),
score=float(record['imdb_score'])))
return directors_movies


def get_average_scores(directors):
'''Filter directors with < MIN_MOVIES and calculate averge score'''
return {(director, _calc_mean(movies)): movies for director, movies in directors.items()
if len(movies) >= MIN_MOVIES}

def _calc_mean(movies):
'''Helper method to calculate mean of list of Movie namedtuples'''
return round(sum((movie.score for movie in movies))/len(movies), 1)


def print_results(directors):
'''Print directors ordered by highest average rating. For each director
print his/her movies also ordered by highest rated movie.
See http://pybit.es/codechallenge13.html for example output'''
fmt_director_entry = '{counter}. {director:<52} {avg}'
fmt_movie_entry = '{year}] {title:<50} {score}'
sep_line = '-' * 60
counter = 0
for director in sorted(directors.items(), key=lambda x: x[0][1], reverse=True):
print()
print(fmt_director_entry.format(counter=counter, director=director[0][0], avg=director[0][1]))
print(sep_line)
for movie in director[1]:
print(fmt_movie_entry.format(year=movie.year, title=movie.title, score=movie.score))
counter += 1


def main():
'''This is a template, feel free to structure your code differently.
We wrote some tests based on our solution: test_directors.py'''
directors = get_movies_by_director()
directors = get_average_scores(directors)
print_results(directors)
# print(get_movies_by_director())


if __name__ == '__main__':
main()
36 changes: 36 additions & 0 deletions 13/pajdekPL/test_directors.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
from directors import get_movies_by_director, get_average_scores, _calc_mean


def test():
directors = get_movies_by_director()

assert 'Sergio Leone' in directors
assert 'Andrew Stanton' in directors # has 3 movies, but not yet filtered
assert len(directors['Sergio Leone']) == 4
assert len(directors['Peter Jackson']) == 12

movies_sergio = directors['Sergio Leone']
movies_nolan = directors['Christopher Nolan']
assert _calc_mean(movies_sergio) == 8.5
assert _calc_mean(movies_nolan) == 8.4

directors = get_average_scores(directors)
assert 'Andrew Stanton' not in directors # director 3 movies now filtered out

expected_directors = ['Sergio Leone', 'Christopher Nolan', 'Quentin Tarantino',
'Hayao Miyazaki', 'Frank Darabont', 'Stanley Kubrick']
expected_avg_scores = [8.5, 8.4, 8.2, 8.2, 8.0, 8.0]
expected_num_movies = [4, 8, 8, 4, 4, 7]
report = sorted(directors.items(), key=lambda x: float(x[0][1]), reverse=True)
for counter, (i, j, k) in enumerate(
zip(expected_directors,
expected_avg_scores, expected_num_movies)):
assert report[counter][0] == (i, j)
assert len(report[counter][1]) == k
assert _calc_mean(report[counter][1]) == j

return "tests pass"


if __name__ == '__main__':
print(test())