(maint) add ed25519 support #3248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tw1r3
force-pushed
the
support-ed25519
branch
7 times, most recently
from
d0adee3
to
301c858
Compare
h0tw1r3
force-pushed
the
support-ed25519
branch
from
301c858
to
9dd0486
Compare
h0tw1r3
force-pushed
the
support-ed25519
branch
4 times, most recently
from
210d00c
to
99cee4d
Compare
h0tw1r3
force-pushed
the
support-ed25519
branch
from
99cee4d
to
bc06d53
Compare
|
@h0tw1r3 did you build a bolt package with some combo of these gems on windows? If so, could you update puppet-runtime with that corresponding change? If this builds we can certainly take this up. |
|
I did built it, will add it to runtime and send it through the standard pipeline. |
|
Thanks, yeah we will need that to be merged before we require these gems in the gemspec :) |
rubygems has compiled versions of bcrypt_pbkdf 1.1.1 for windows and now compile correctly all platforms with a supported ruby dev environment addresses #1987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubygems has compiled releases of bcrypt_pbkdf >= 1.1.0 for windows, and >= 1.1.1 compile correctly on all supported ruby platform/compiler combinations.
addresses #1987