Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm: Update ppm submodule to commit a2ade745bfbc5f #725

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Sep 17, 2023

Context

This is a re-do of #712, to include a newer node-gyp version that should fix an issue with code-signing the Pulsar app on macOS.

For purposes of auto-closing the old ppm bump PR if this merges: This PR resolves #712.

How to do this kind of update:

When the changes you want are live at the default branch of ppm repo (https://github.com/pulsar-edit/ppm), run the following command in the root of the core repo to update the ppm submodule in the core repo:

git submodule update --remote ppm.

Summary of Changes

Includes a lot of decaf work from multiple contributors, migrates from first-mate dependency to second-mate, a small code refactor, a Windows postinstall script fix, and switching to our fork of npm 6 that includes node-gyp 9.x.

Specifically with regard to node-gyp, and this is updated since #712, we are now on the latest node-gyp commit from node-gyp's default main branch. This includes a fix for some unforeseen consequences of a change I authored in node-gyp. The change in question that caused the code signing issues in macOS: nodejs/node-gyp@b9ddcd5.

So, ppm bumped node-gyp to the latest commit from node-gyp repo's main branch, currently nodejs/node-gyp@d3615c6.

This includes a fix for better compatibility with app signing on macOS (nodejs/node-gyp@0f1f667). Hopefully it works! 🤞

Includes the following PR's from ppm repo:

Verification process

Includes a lot of decaf work from multiple contributors,
a dependency bump, a small code refactor and a Windows postinstall fix
and switching to our fork of npm 6 that includes node-gyp 9.x.
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was the one merging or authoring many of these changes here, lets get it into core!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Sep 20, 2023

The macOS signing bit of the "build Pulsar binaries" CI workflow seems to be happy with this change.

(Still investigating why my computer doesn't like Pulsar's signed binaries lately, but this does appear to be signed. 🤷).

Good enough for me.


Thank you for the review, merging!

@DeeDeeG DeeDeeG merged commit a82b4d0 into master Sep 20, 2023
99 checks passed
@DeeDeeG DeeDeeG deleted the update-ppm-a2ade745bf branch September 20, 2023 02:44
confused-Techie added a commit that referenced this pull request Sep 23, 2023
confused-Techie added a commit that referenced this pull request Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants