ppm: Update ppm submodule to commit a2ade745bfbc5f #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a re-do of #712, to include a newer node-gyp version that should fix an issue with code-signing the Pulsar app on macOS.
For purposes of auto-closing the old ppm bump PR if this merges: This PR resolves #712.
How to do this kind of update:
When the changes you want are live at the default branch of ppm repo (https://github.com/pulsar-edit/ppm), run the following command in the root of the core repo to update the ppm submodule in the core repo:
git submodule update --remote ppm
.Summary of Changes
Includes a lot of decaf work from multiple contributors, migrates from
first-mate
dependency tosecond-mate
, a small code refactor, a Windows postinstall script fix, and switching to our fork of npm 6 that includes node-gyp 9.x.Specifically with regard to node-gyp, and this is updated since #712, we are now on the latest node-gyp commit from node-gyp's default
main
branch. This includes a fix for some unforeseen consequences of a change I authored in node-gyp. The change in question that caused the code signing issues in macOS: nodejs/node-gyp@b9ddcd5.So, ppm bumped node-gyp to the latest commit from node-gyp repo's main branch, currently nodejs/node-gyp@d3615c6.
This includes a fix for better compatibility with app signing on macOS (nodejs/node-gyp@0f1f667). Hopefully it works! 🤞
Includes the following PR's from ppm repo:
master
ppm#81postinstall
scripts work on Windows with spaces in cwd path ppm#83visualStudioIsInstalled()
ppm#85second-mate
and removefirst-mate
ppm#86Skip update checks for bundled packages ppm#91was reverted in Revert "Skip update checks for bundled packages" ppm#96 ]Verification process