[BLOG] Pulsar's CI #231
Merged
[BLOG] Pulsar's CI #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daeraxa
reviewed
Sep 4, 2023
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
Co-authored-by: Daeraxa <[email protected]>
confused-Techie
commented
Sep 4, 2023
|
@Daeraxa as always I very much appreciate you doing such a rad job at cleaning up my train of thought here. I've added all the suggestions you made and even did a final look through to make sure nothings missed. |
Daeraxa
approved these changes
Sep 5, 2023
|
Alright, with approval from @Daeraxa (Which thanks again for the review) looks like we are good to go, lets get this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blog post details our CI changes, what that means for users, and what it took for us to get there.