Miscellaneous fixes, part 3 #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…because the page has widened in scope. Other minor tweaks as well.
…in order to allow hovercard links for the `snippets` package to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we land PRs that fix issues around terminal commands, I've been tweaking the instructions on that page.
This PR should not land until we ship 1.121 — at this point I'm confident we'll have pulsar#1071 landed by then.
I also updated the submodules. Hovercard links to the
snippetspackage weren't showing a hovercard, and I'm pretty sure that's because we were still using a version of Pulsar that hadn't yet migratedsnippetsinto the core repo. Updating seems to have fixed that.I'll keep adding to this PR as necessary.