Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: run e2e tests before deploying #710

Merged
merged 3 commits into from
Oct 16, 2024
Merged

dev: run e2e tests before deploying #710

merged 3 commits into from
Oct 16, 2024

Conversation

tefkah
Copy link
Contributor

@tefkah tefkah commented Oct 10, 2024

  • dev: make e2e tests run on promotion to main
  • fix: make deploy wait for e2e, duh

Issue(s) Resolved

High-level Explanation of PR

We should probably be good children and eat our vegetables and just run e2e tests on promotion to main even though we require you to run be up to speed with main anyway.

Test Plan

Screenshots (if applicable)

Notes

Copy link
Member

@kalilsn kalilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hate to say it but i think you are right!

@tefkah tefkah merged commit c2cb99f into main Oct 16, 2024
8 checks passed
@tefkah tefkah deleted the tfk/run-e2e-on-main branch October 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants