Fix stage deletion by removing unused tables #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tables aren't used by our code anymore and were originally intended to keep a history of claims and moves on a pub. Since we're not doing that currently I have removed both tables to avoid any confusion
kalilsn
commented
Oct 7, 2024
| @@ -154,9 +153,6 @@ export default async function Page({ | |||
| ) : null} | |||
| </div> | |||
| </div> | |||
| <div> | |||
| <MembersAvatars pub={pub} /> | |||
| </div> | |||
There was a problem hiding this comment.
This wasn't rendering anything on most pubs, and it's confusing when it is rendered. See the "Assigned To" section on this pub
kalilsn
requested review from
tefkah and
allisonking
and removed request for
tefkah
tefkah
approved these changes
Oct 8, 2024
core/prisma/schema.prisma
Outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #632
High-level Explanation of PR
The unjournal stages that can't be deleted have a foreign key reference to some unused tables that were intended to track history of assignment and stage movement, but aren't used anymore. Dropping those stages will allow the IDs to be fixed.
Test Plan