-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stage deletion by removing unused tables #697
Conversation
These tables aren't used by our code anymore and were originally intended to keep a history of claims and moves on a pub. Since we're not doing that currently I have removed both tables to avoid any confusion
@@ -154,9 +153,6 @@ export default async function Page({ | |||
) : null} | |||
</div> | |||
</div> | |||
<div> | |||
<MembersAvatars pub={pub} /> | |||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't rendering anything on most pubs, and it's confusing when it is rendered. See the "Assigned To" section on this pub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll have a look at the draft PR to see if that's feasible, but otherwise great work!
core/prisma/schema.prisma
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good changes!
Resolves #632
High-level Explanation of PR
The unjournal stages that can't be deleted have a foreign key reference to some unused tables that were intended to track history of assignment and stage movement, but aren't used anymore. Dropping those stages will allow the IDs to be fixed.
Test Plan