Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify remaining uses of wd0b5 and wd11e #463

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

Rangi42
Copy link
Member

@Rangi42 Rangi42 commented Sep 10, 2024

Fixes #456, and makes pokered 100% labeled!

$ tools/unnamed.py -r . -l 30 pokered.sym
Unnamed pokered symbols: 0 (100.00% complete)

Formerly wd0b5:

  • wCurSpecies is copied from Gen 2. It's primarily the input argument to GetMonHeader (aka GetBaseData in Gen 2).
  • wNameListIndex is one argument to GetName, along with wNameListType (which says whether the index is for a mon, move, item, or trainer).

Formerly wd11e:

  • wNamedObjectIndex is copied from Gen 2. I could have defined separate labels for Pokemon, item, and move IDs, but there's enough overlap (e.g. functions that sometimes print one and sometimes another, or how the generic GetName outputs to this) that I thought this was better.
  • wTempByteValue is copied from Gen 2. Used in a few places for very local values, e.g. a place to stash+retrieve a value that's used only in one function or even in one "paragraph" of one function.
  • wPokedexNum is "the IndexToPokedex or PokedexToIndex variable"; it acts as both input and output, i.e. both species and Pokedex number.
  • wTempTMHM is copied from Gen 2. It's "the TMToMove variable" (aka GetTMHMMove in Gen 2): it acts as both input and output, e.g. both TM item number and move number.
  • wMoveGrammar is copied from Gen 2. It's "the DetermineExclamationPointTextNum variable" (aka GetMoveGrammar in Gen 2): it acts as both input and output, i.e. both move ID and grammar/exclamation index (0-3).

@Rangi42 Rangi42 requested a review from dannye September 10, 2024 04:47
@Rangi42 Rangi42 changed the title Identify remaining uses of wd11e Identify remaining uses of wd0b5 and wd11e Sep 10, 2024
Copy link
Member

@dannye dannye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@Rangi42 Rangi42 merged commit 5a622f6 into pret:master Sep 19, 2024
1 check passed
@Rangi42 Rangi42 deleted the wd11e branch September 19, 2024 01:42
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label the last two multi-purpose WRAM locations, wd0b5 and wd11e
2 participants