Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wOAMBuffer -> wShadowOAM #370

Merged
merged 5 commits into from
Jul 9, 2022
Merged

wOAMBuffer -> wShadowOAM #370

merged 5 commits into from
Jul 9, 2022

Conversation

rawr51919
Copy link
Contributor

@rawr51919 rawr51919 commented Jul 1, 2022 •
edited
Loading

ISSOtm, as he pointed out in pret/pokecrystal#943 (comment), noticed that the WRAM constant wOAMBuffer is, by most usage and convention elsewhere, known as wShadowOAM instead.
This PR aims to rename this particular WRAM constant so that it matches this convention.
pokegold companion PR: pret/pokegold#99
pokegold-spaceworld companion PR: pret/pokegold-spaceworld#103
pokecrystal companion PR: pret/pokecrystal#971
This also works toward bullet point 3 in #315 by syncing this OAM constant across all Gen 1 and 2 main series pret repos

This was referenced Jul 1, 2022
Merged
Merged
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/battle/core.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/events/diploma.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/gfx/mon_icons.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/items/town_map.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/items/town_map.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/items/town_map.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/items/town_map.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 3, 2022
View reviewed changes
engine/movie/splash.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 changed the title wOAMBuffer->wShadowOAM as per convention wOAMBuffer -> wShadowOAM Jul 9, 2022
vulcandth
vulcandth approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@vulcandth vulcandth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There you go. This looks good; thanks.

Rangi42
Rangi42 reviewed Jul 9, 2022
View reviewed changes
engine/movie/title2.asm Outdated Show resolved Hide resolved
Rangi42
Rangi42 reviewed Jul 9, 2022
View reviewed changes
engine/overworld/cut2.asm Outdated Show resolved Hide resolved
@Rangi42 Rangi42 merged commit cc46b0e into pret:master Jul 9, 2022
github-actions bot pushed a commit that referenced this pull request Jul 9, 2022
@Rangi42
wOAMBuffer -> wShadowOAM (#370)
a33cdf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vulcandth vulcandth vulcandth approved these changes

@Rangi42 Rangi42 Rangi42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rawr51919 @vulcandth @Rangi42