Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send export files event in google analytics v4 #1175

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

richard015ar
Copy link
Contributor

Issue: pressbooks/pressbooks#3412

Related PR: pressbooks/pressbooks#3428

This PR sends download events using Google Analytics 4.

Testing case

  • Ensure you have Google Analytics 4 ID configured correctly:
    • Go to Network Level > Settings > Google Analytics and make sure only 1 Google Analytics field is available to fill/update.
    • Add a Google ID. Ask the team for a test Google Analytics ID, and Google Analytics admin access to watch the real-time events.
  • Go to a book page with exported files to be able to download any export from the home page.
  • You should be able to watch the download event in real-time events in the Google Analytics admin platform.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1175 (f68e738) into dev (d42497c) will not change coverage.
The diff coverage is n/a.

❗ Current head f68e738 differs from pull request most recent head 69c50c5. Consider uploading reports for the commit 69c50c5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1175   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files           3        3           
  Lines         574      574           
=======================================
  Hits          273      273           
  Misses        301      301           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42497c...69c50c5. Read the comment docs.

Copy link
Contributor

@fdalcin fdalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However we're changing the event name from exportFiles to export_files would that impact users? If so, wouldn't it be better to keep the previous name?

@richard015ar
Copy link
Contributor Author

@fdalcin I think it may impact clients, I will change it.

@fdalcin fdalcin merged commit ce453d9 into dev Aug 1, 2023
6 checks passed
@fdalcin fdalcin deleted the fix/track-download-ga4 branch August 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants