Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous nick plugin #920

Closed
wants to merge 7 commits into from
Closed

Previous nick plugin #920

wants to merge 7 commits into from

Conversation

f0und3r
Copy link

@f0und3r f0und3r commented Jan 17, 2017

No description provided.

@prawnsalad
Copy link
Owner

Looks good!

A few changes need to be made before I can accept this though.

  1. PRs need to be sent to the development branch only
  2. Indentation should be 4 spaces
  3. Lines must end with semi colons
  4. The auto connect should be left to another plugin. It is out of scope for a plugin called previous_nick and I never recommend auto connecting due to abuse anyway.

landergate
landergate reviewed Jan 17, 2017
View reviewed changes
client/assets/plugins/previous_nick.html

if (previous_nick) {
elm.val(previous_nick)
btn.submit()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe autoconnect must be optional and not forced? In case if user wants to change his nickname before connecting.

@f0und3r f0und3r mentioned this pull request Jan 18, 2017
Open
@f0und3r
Copy link
Author

f0und3r commented Jan 18, 2017

New pr #922

@f0und3r f0und3r closed this Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landergate landergate landergate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@f0und3r @prawnsalad @landergate