Termination signals aren't being forwarded

[sergejostir]

Panel Version: all
Daemon Version: all
Service: all
Docker Image: all
Modified: no

Errors that you are experiencing:
Entrypoint start the server process by using fork (so that the new process is spawned and the entrypoint stays PID 1). Shell doesn't forward termination signals by default, so all eggs that depend on SIGINT (or any other signal) to gracefully stop the container currently don't work as expected.

The server process should be started using "exec", so it replaces the current process and takes the PID 1. This way termination signals sent to the container will actually reach the server process which can then act accordingly.

[sergejostir]

That commit makes it that you can specify the signal you want to send, but it won't fix anything because the signal will never propagate to the actual server process.

[matthewpi]

I can confirm this fix works. I changed all my images to use exec instead of eval and now a ^C signal properly works, for this testing I was using my go1.15 image with go run main.go as the startup command. Before the change from eval to exec, pressing stop would cause the app to be marked as stopping for around 10 seconds, then be was marked as offline; after the change, the app was marked as offline almost immediately after pressing the stop button.