-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Termination signals aren't being forwarded #73
Comments
That commit makes it that you can specify the signal you want to send, but it won't fix anything because the signal will never propagate to the actual server process. |
I can confirm this fix works. I changed all my images to use |
Change `eval` to `exec` fix parkervcp/images#73
Panel Version: all
Daemon Version: all
Service: all
Docker Image: all
Modified: no
Errors that you are experiencing:
Entrypoint start the server process by using fork (so that the new process is spawned and the entrypoint stays PID 1). Shell doesn't forward termination signals by default, so all eggs that depend on SIGINT (or any other signal) to gracefully stop the container currently don't work as expected.
The server process should be started using "exec", so it replaces the current process and takes the PID 1. This way termination signals sent to the container will actually reach the server process which can then act accordingly.
The text was updated successfully, but these errors were encountered: