-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
^C does not send a SIGINT to the server #3679
Comments
Pretty sure this is the eval vs exec issue. I still think we could change the way containers start with the entrypoint and commands. |
Tested this and it's indeed caused by the Docker image entrypoint startup eval and works fine with exec, as discussed in the past at #3042 and parkervcp/images#73 Some eggs have script-like startups that the exec can't parse properly (ex. Discord and ark eggs), I think we can make the rest of the images and eggs work with it. Pretty sure @matthewpi was working on changing how the startup args are passed to Wings? |
Maybe Wings could check if the stop command is a specific set of text such as "SIGINT" and just kill the container if that is what the stop command is, if not just run the provided command. |
Sadly, we can't actually send a However, ContainerStop sends a proper SIGINT signal, it's the entrypoints of eggs that use The |
Is there an existing issue for this?
Current Behavior
Using
^C
as the stop command does not send a SIGINT to the server, but^^C
does.Expected Behavior
^C
as the stop command should send a SIGINT to the server.Steps to Reproduce
Set the stop command as
^C
then try to stop the serverPanel Version
1.6.2
Wings Version
1.5.1
Error Logs
None
The text was updated successfully, but these errors were encountered: