[test/do not merge] Add zoralabs-openzeppelin-contracts as a submodule to monorepo #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
oveddan
changed the title
oveddan
changed the title
|
What if we just copied the files in monorepo style? |
This is just a draft while I try a few things; I thought of doing that, and it's surely simpler, but then we lose the commit history from openzeppelins/contracts, which was the reason we created a fork originally for our version of that repo |
|
Hmm, I see. Could we copy in the original files then make another commit that makes the changes we made to those files? May be too difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft trying out adding
https://github.com/ourzora/openzeppelin-contracts-upgradeableas a submodule to the packages folder, allowing it to be included in the protocol monorepo. The reason to add it as a submodule is this way we can preserve commit history.This paves the way to make it easier to install the contracts from the monorepo using forge.