-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Premint - if no mint recipient, revert with proper error #312
Conversation
44d4d68
to
9b93a9e
Compare
dcc098e
to
1ab0bb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to understand the motivation for this pr.
@@ -120,7 +120,8 @@ library ZoraCreator1155PremintExecutorImplLib { | |||
uint256 quantityToMint, | |||
IZoraCreator1155PremintExecutor.MintArguments memory mintArguments | |||
) internal { | |||
bytes memory mintSettings = abi.encode(mintArguments.mintRecipient, mintArguments.mintComment); | |||
address mintRecipient = mintArguments.mintRecipient == address(0) ? msg.sender : mintArguments.mintRecipient; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what case would this be true?
In case it's not set by accident |
hmm i wonder if its better to leave this explicit and let it revert if a recipient isn't passed |
9b93a9e
to
de4d708
Compare
1ab0bb6
to
e9c6066
Compare
de4d708
to
8247170
Compare
b9d5595
to
9602e4e
Compare
fab7fcc
to
58b0ceb
Compare
9602e4e
to
f69802c
Compare
58b0ceb
to
cbcd00e
Compare
f69802c
to
1164900
Compare
cbcd00e
to
3a22cd0
Compare
1164900
to
5d465d3
Compare
3a22cd0
to
e7fcba1
Compare
5d465d3
to
388f2d7
Compare
e7fcba1
to
4e5a9e9
Compare
388f2d7
to
26a3e3e
Compare
Merge activity
|
4e5a9e9
to
83ba3eb
Compare
26a3e3e
to
db0f740
Compare
The base branch was changed.
db0f740
to
bf2eb9d
Compare
No description provided.