Add back coverage ci task, and fix fork tests to not run into compliation issues when running coverage report #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oveddan
commented
Sep 12, 2023
•
oveddan
commented
- Fix coverage compilation errors by moving some fork tests steps to private functions and preventing stack too deep error
- Adding back minimum test coverage requirement, setting it to 89 as currently in this branch it's 89.4%
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
oveddan
changed the title
Set minimum to 89 for now.
kulkarohan
approved these changes
Sep 12, 2023
iainnash
pushed a commit
that referenced
this pull request
Jan 11, 2024
Add back coverage ci task, and fix fork tests to not run into compliation issues when running coverage report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.