Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zora legacy media fixes & doc updates #79

Merged
merged 7 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

## v0.1.5

- bump web3 dependency to latest version
- fix zora legacy media parsing
- update release docs

## v0.1.4

Expand Down
2 changes: 1 addition & 1 deletion docs/contributing/publish_release.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Make sure your versions are appended with `v`. This will be the version publishe
All releases must be made with a GPG signed tag. Don't create a tag without signing it.

```bash
git tag -asm "v0.0.2"
git tag -sm "v0.0.2"
git push origin v0.0.2
```

Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Getting Started

Documentation for version: **v0.1.4**
Documentation for version: **v0.1.5**

## Overview

Expand Down
2 changes: 1 addition & 1 deletion offchain/metadata/parsers/collection/collection_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@ def should_parse_token(self, token: Token, *args, **kwargs) -> bool:
Returns:
bool: whether or not the collection parser handles this token.
"""
return token.collection_address in [address.lower() for address in self._COLLECTION_ADDRESSES]
return token.collection_address.lower() in [address.lower() for address in self._COLLECTION_ADDRESSES]
2 changes: 1 addition & 1 deletion offchain/metadata/parsers/collection/zora.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def get_content_details(self, uri: str) -> Optional[MediaDetails]:
return None

def parse_metadata(self, token: Token, raw_data: Optional[dict], *args, **kwargs) -> Optional[Metadata]:
if token.uri is None or raw_data is None:
if token.uri is None or raw_data is None or not isinstance(raw_data, dict):
token.uri = self.get_uri(token.token_id)
raw_data = self.fetcher.fetch_content(token.uri)

Expand Down
813 changes: 371 additions & 442 deletions poetry.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ requests = "^2.28.1"
pydantic = "^1.9.2"
python-json-logger = "^2.0.4"
urllib3 = "^1.26.11"
web3 = ">=5.30.0 <=6.7.0"
web3 = "^5.30.0"
tenacity = "^8.0.1"

[tool.poetry.dev-dependencies]
Expand Down
Loading