Add partial soulbound token #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainnash
reviewed
Aug 23, 2023
| /// @title IToken | ||
| /// @author Neokry | ||
| /// @notice The external Token events, errors and functions | ||
| interface IPartialSoulboundToken is IUUPS, IERC721Votes, IBaseToken, IERC5192, PartialSoulboundTokenTypesV1 { |
There was a problem hiding this comment.
nit: personally i prefer account- compared to soul- bound tokens, even though i know vitalik wrote about soul-bound they technically really are closer to account-bound and the terminology feels cleaner for me.
|
A bitmap makes sense here since it saves gas for the next user within the 256 chunk slot. Another option (perhaps fine on l2) is just to do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds partial soulbound token implementation for colleciton plus: https://hackmd.io/eFSgnXefSUujGr75EqPCCg
transferFromAndLockto allow minters to lock tokens to a specified accountCode review: