Add media metadata renderer #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainnash
reviewed
Sep 8, 2023
| address _newRendererImpl, | ||
| bytes memory _setupRenderer | ||
| ) external returns (address metadata) { | ||
| if (msg.sender != IOwnable(_token).owner()) revert ONLY_TOKEN_OWNER(); |
There was a problem hiding this comment.
nit: it's nice to always use { and } brackets to prevent bugs and readability.
iainnash
approved these changes
Sep 11, 2023
| tokenAttributes[i + 1] = uint16(seed % numItems); | ||
|
|
||
| // Adjust the randomness | ||
| seed >>= 16; |
There was a problem hiding this comment.
nit: this comment is a bit strange – get next 16 random bits likely makes more sense.
| @@ -50,6 +50,19 @@ interface IPropertyIPFSMetadataRenderer is IBaseMetadata, MetadataRendererTypesV | |||
| /// | |||
| error TOO_MANY_PROPERTIES(); | |||
|
|
|||
| error TOKEN_ALREADY_GENERATED(uint256 tokenId); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new metadata renderer and allows for custom metadata renderer
Code review