Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] feat: Add Escrow Milestones Transaction Type #487

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

[DRAFT] feat: Add Escrow Milestones Transaction Type #487

wants to merge 62 commits into from

Conversation

wtfsayo
Copy link

@wtfsayo wtfsayo commented Oct 28, 2024

Description

Motivation & context

Code review

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have done a self-review of my own code
  • Any new and existing tests pass locally with my changes
  • My changes generate no new warnings (lint warnings, console warnings, etc)

wtfsayo and others added 30 commits September 25, 2024 13:05
@wtfsayo
add escrow proposal type to list
e707961
@wtfsayo
add escrow icon
1547b47
@wtfsayo
add proto-escrow-form
8f46c27
@wtfsayo
save: progress escrow form
6ce9bfb
@wtfsayo
WIP: form mechanics
af644e7
@wtfsayo
add temp logger
b93c1d3
@wtfsayo
Update .gitignore
56ab471
@wtfsayo
minor improvements
b6e8391
@wtfsayo
add upload feature
25ef3fa
@wtfsayo
progress: prepare data for ipfs upload
995d7a1
@wtfsayo
save: improve form UX
1c34d65
@wtfsayo
feat: ipfs upload of escrow data
ce646ac
@wtfsayo
form error ux
069bfb8
@wtfsayo
ready to tx
cbcc7fe
@wtfsayo
feat: create escrow proposal
9d2133e
@wtfsayo
add safe wallet
3e4f587
@wtfsayo
improve add txn to queue button UX
3bbe54d
@wtfsayo
switch to Smart Input
108812e
@wtfsayo
update ipfs metadata format
7a9a086
@wtfsayo
ipfs bytes convert fix
4a064c0
@wtfsayo
type issue with value
8827368
@wtfsayo
add better summary
8bfb79f
@wtfsayo
fix precision pt errors
ec18399
@wtfsayo
add formstore and minor improvements
4ca79c9
@wtfsayo
update escrow detail display and treasury amt alert
f654e34
@wtfsayo
implement CR feedback
deadbcb
@wtfsayo
minor updates with date
a0377d8
@wtfsayo
Merge pull request #20 from SmartInvoiceXYZ/feat/escrow-proposal
52edffa 
Escrow Proposal Creation Flow
@wtfsayo
Merge branch 'ourzora:main' into main
63c1b34
@wtfsayo
add display deployEscrow
ded99b2
wtfsayo and others added 24 commits October 19, 2024 22:40
@wtfsayo
wip: release button
c04a2dc
@wtfsayo
fix safetyvalve helpertext
9105066
@dan13ram
added executionTxHash to proposal entity
1819b00
@dan13ram
updated sepolia subgraph link - temporary
83f4a08
@wtfsayo
Merge pull request #21 from SmartInvoiceXYZ/feat/executionTxHash
61bbe28 
added executionTxHash to proposal entity
@wtfsayo
add test for client and recipient address being diff
77828cf
@wtfsayo
update subgraph-queries with executionTransactionHash
f01ae27
@wtfsayo
lint issues cleanup
c138f9e
@wtfsayo
progress: allow release milestones
b55f1fc
@wtfsayo
add milestone txn decoding
0a3c2fb
@wtfsayo
fix: auto decode release(_milestone)
12cc20d
@wtfsayo
Update EscrowUtils.ts
bbdf453
@wtfsayo
feat: add daoMultiSig via EAS
75145d4
@wtfsayo
Update SmartContracts.tsx
a3aad62
@wtfsayo
fix: fetch multisig + feat: conditional redirect for milestones
3b6993e
@wtfsayo
added daoGoverner or multiSig as default
ff11beb
@wtfsayo
hide input field if multiSig found
71cf100
@wtfsayo
refactor Milestone details component
f203d9f
@wtfsayo @dan13ram
Update apps/web/src/modules/create-proposal/components/TransactionFor…
29c92be 
…m/Escrow/EscrowForm.tsx

Co-authored-by: Dan OneTree <[email protected]>
@wtfsayo
use lowerCase compare/ apply CR comments
fbcae1b
@wtfsayo
remove validation on change + allow button to validate on click
fbc9743
@wtfsayo
Merge pull request #25 from SmartInvoiceXYZ/feat/view-escrow
34628c3 
Feat/view escrow
@wtfsayo
fix:the bundler address
9347dab
@wtfsayo
Merge branch 'ourzora:main' into main
276146e
@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024

@wtfsayo is attempting to deploy a commit to the Nouns Builder Team on Vercel.

A member of the Team first needs to authorize it.

@wtfsayo wtfsayo changed the title [DRAFT] Add Escrow Milestones Transaction Type [DRAFT] feat: Add Escrow Milestones Transaction Type Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtfsayo @dan13ram