OCPBUGS-42605: OCPBUGS-42244: Exporting environment varialbe NODE_CNI for live migration #2532
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@pliurh: This pull request references Jira Issue OCPBUGS-42605, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
| @@ -70,7 +70,7 @@ spec: | |||
| set -euo pipefail | |||
| {{- if .IsNetworkTypeLiveMigration }} | |||
| set -x | |||
| NODE_CNI="OpenShiftSDN" | |||
| export NODE_CNI="OpenShiftSDN" | |||
There was a problem hiding this comment.
this is a bit confusing:
export NODE_CNI="OpenShiftSDN"
if ip link show br-ex; then
echo "br-ex exists"
NODE_CNI="OVNKubernetes"
else
echo "br-ex doesn't exist"
fi
can we keep NODE_CNI exported in both cases?
By checking the environment varialbe NODE_CNI, the CNI processes can know if it shall run in the live migration mode. Signed-off-by: Peng Liu <[email protected]>
pliurh
force-pushed
the
live_migration
branch
from
d1ba22a
to
369f224
Compare
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@pliurh: This pull request references Jira Issue OCPBUGS-42605, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.17 release-4.16 release-4.15 |
|
@pliurh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
@pliurh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit de12283
into
openshift:master
|
@pliurh: Jira Issue OCPBUGS-42605: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-42605 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pliurh: new pull request created: #2536 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
|
/cherry-pick release-4.16 |
|
/cherry-pick release-4.15 |
|
@zhaozhanqi: new pull request created: #2538 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@zhaozhanqi: new pull request created: #2539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
By checking the environment varialbe NODE_CNI, the CNI processes can know if it shall run in the live migration mode.