-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-42605: OCPBUGS-42244: Exporting environment varialbe NODE_CNI for live migration #2532
Conversation
@pliurh: This pull request references Jira Issue OCPBUGS-42605, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@@ -70,7 +70,7 @@ spec: | |||
set -euo pipefail | |||
{{- if .IsNetworkTypeLiveMigration }} | |||
set -x | |||
NODE_CNI="OpenShiftSDN" | |||
export NODE_CNI="OpenShiftSDN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit confusing:
export NODE_CNI="OpenShiftSDN"
if ip link show br-ex; then
echo "br-ex exists"
NODE_CNI="OVNKubernetes"
else
echo "br-ex doesn't exist"
fi
can we keep NODE_CNI
exported in both cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
By checking the environment varialbe NODE_CNI, the CNI processes can know if it shall run in the live migration mode. Signed-off-by: Peng Liu <[email protected]>
d1ba22a
to
369f224
Compare
/jira refresh |
@pliurh: This pull request references Jira Issue OCPBUGS-42605, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, pliurh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.17 release-4.16 release-4.15 |
@pliurh: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
@pliurh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
de12283
into
openshift:master
@pliurh: Jira Issue OCPBUGS-42605: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-42605 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@pliurh: new pull request created: #2536 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: cluster-network-operator |
/cherry-pick release-4.16 |
/cherry-pick release-4.15 |
@zhaozhanqi: new pull request created: #2538 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@zhaozhanqi: new pull request created: #2539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
By checking the environment varialbe NODE_CNI, the CNI processes can know if it shall run in the live migration mode.