Bugfix/issue 27 invalid item access #29
Open
+42
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #27
Scheduled event handlers can run after a call to
disconnect
on the client. The conversation object has been cleared so item lookups cause an error to be thrown in some handlers.With these changes, the event handler function returns early if the client is not connected, before trying to look up items.
A test case has been added, however the error triggers after the successful completion of the test. Not sure how to wait for all scheduled event handlers to run in the test.