feat(condo): DOMA-10226 add full stacked gql error traces #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…full trace to developer in case of jest error
|
pahaz
changed the title
pahaz
commented
Sep 20, 2024
| * @param {Error} error -- any error | ||
| * @param {Boolean} hideInternals -- do you need to hide some internal error fields | ||
| * @param {Boolean} applyPatches -- do you need to apply a common error message patches | ||
| * @returns {import('graphql').GraphQLFormattedError} | ||
| */ | ||
| const safeFormatError = (error, hideInternals = false, applyPatches = true) => { | ||
| const safeFormatError = (errorIn, hideInternals = false, applyPatches = true, _isRecursionCall = false) => { |
There was a problem hiding this comment.
It’s better to create another internal function with third argument.
pahaz
commented
Sep 20, 2024
| @@ -138,7 +137,7 @@ function setAllFeatureFlags (value) { | |||
| function setFakeClientMode (entryPoint, prepareKeystoneOptions = {}) { | |||
| if (__expressApp !== null) return | |||
| if (__isAwaiting) return | |||
| console.warn('setFakeClientMode(): you changed the test execution mode to FAKE client! Your test will not really make a request to remote server! Use it only for local debugging or .spec.js tests cases') | |||
| // console.warn('setFakeClientMode(): you changed the test execution mode to FAKE client! Your test will not really make a request to remote server! Use it only for local debugging or .spec.js tests cases') | |||
There was a problem hiding this comment.
It looks like some local development stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve developer experience. And show what the real original error. And provide a full stack trace with internal and intermediate errors.