Feat(condo): DOMA-10067 normalizing unit name #5191
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessary test cases, fixed roman numbers with ru locale, removing emojis
…s when user and billingReceipt have same unitName but with words in different registries
YEgorLu
added
✋🙂 Review please
|
There was a problem hiding this comment.
It's common practice to use functions instead of anonymous arrow function when making utils
There was a problem hiding this comment.
it's easier to debug and understan the traces
| ['0-1', '0-1'], | ||
| ['3-8-13\n', '3-8-13'], | ||
| ['050-2/1', '050-2-1'], | ||
| ['кл.кл. 3 (19Б кв. 14)', '3-19-b-14'], |
There was a problem hiding this comment.
Who is responsible for list of abbreviations?
SavelevMatthew
requested changes
Sep 5, 2024
There was a problem hiding this comment.
This feature needs to be discussed first, I've got a lot of questions related to the decisions you've and @dkoviazin made
pahaz
reviewed
Sep 5, 2024
dkoviazin
added
the
🔬 WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added function for unit name normalization and used it in allResidentBillingReceipts.
Problem in allResidentBillingReceipts was that user can have unit name like '12a', and billing receipt says '12A' and we needed way to say that they are equal
There are many cases when users describe unitName strangely, tests may not have covered all of them, so the plan is to extend normalization in the future if needed
Added slugify package to make translation of symbols from other languages to english more convenient.