-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idr front page #91
Idr front page #91
Conversation
thank you @will-moore
|
<div class="panel" style="float: left; width: 100%"> | ||
<div class="small-12 medium-1 large-2 columns"> </div> | ||
<div class="stats small-12 medium-9 large-8 columns" style="position: relative"> | ||
12 Million Images <span>|</span> 300 TB <span>|</span> 102 Studies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly for a follow-up PR, how do you propose to source this data? It is currently maintained in https://github.com/IDR/idr.openmicroscopy.org/blob/master/_data/releases.tsv and used by the Jekyll website although it looks like we need to have it consumed in several places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could try to load it from there. I was also thinking that the numbers should be different in the Cell and Tissue IDR sections, but I guess we don't have those numbers anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct, we do not collect global release statistics differentiating tissue/cell studies at the moment.
Since you are already filtering the studies to display the thumbnails, it should also be possible to make use of https://github.com/IDR/idr.openmicroscopy.org/blob/master/_data/studies.tsv and compute these numbers on the fly.
When under either https://idr-testing.openmicroscopy.org/cell/ or https://idr-testing.openmicroscopy.org/tissue, clicking on the |
@sbesson I think that's a CSS caching issue again. Looks OK for me ;) |
The issues reported in #91 (comment) were related to the deployment using https://github.com/IDR/deployment and the fact the gallery needs to be deployed on all servers (omeroreadwrite + 4 omeroreadonly) to work with the nginx caching. After fixing the deployment, the thumbnails are now displaying as expected. Adding some feedback from @jrswedlow who performed some testing in incognito Chrome Window
|
Re: #91 (comment)
|
After discussion with IDR team & Jason this morning, removed the "only show 4 rows of thumbnails" to show them all now, with a limit of ~6 rows. |
|
||
_url += '?limit=1'; // just get first plate | ||
loadStudyStats = function(callback) { | ||
const url = "https://raw.githubusercontent.com/IDR/idr.openmicroscopy.org/master/_data/studies.tsv"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned today, the downside of depending on the master
is that studies.tsv
will include unreleased statistics.
I have not been able to find a native Jekyll way to expose CSV files as raw files so that they could be directly consumed. On the other side, the IDR deployment is currently constructed as follows:
/
proxies theomero-gallery
application deployed on each read-only Web deployment/about
serves the static content built from https://github.com/IDR/idr.openmicroscopy.org
So having gallery depending on static files under /about
would probably create some unnecessary complexity.
An alternative could be to update the deployment playbook to deploy the static content under /about
and also copy studies.csv
in a static location of the OMERO read-only deployments where it could be consumed by the new omero-gallery
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another alternative which does not completely break the deployment is to make this URL or at least the ref configurable.
We already have a variable containing the tag for the static website and this could easily be used to retrieve the studies.tsv e.g. https://raw.githubusercontent.com/IDR/idr.openmicroscopy.org/2022.02.28-1/_data/studies.tsv in this case.
Exchange the teaser video: Sars-cov typo
Exchange analysis tab video because of Sars... typo
Capturing the output of some minimal testing of the filter box A few comments:
Overall, while I think the new filtering functionality addresses a clear need, I feel like the results view does not have the same level of maturity and testing as the rest of the new UI. Whether to bring this to production immediately or as a second step is a decision we will need to make as a team. |
Updates to IDR front page.
Draft PR to allow others to try, feedback etc.
But not intended to merge in it's current form...
TODO:
Notebooks
See also IDR/idr.openmicroscopy.org#144 and IDR/idr.openmicroscopy.org#140