Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2707 - Logical and textual defs acinar cell of sebaceous gland #2711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Caroline-99
Copy link
Collaborator

  • Fixed the logical defintion
  • Improved textual defs to align with the logical definition and provided references

- Fixed the logical defintion
- Improved textual defs to align with the logical definition and provided references
@dosumis
Copy link
Contributor

dosumis commented Oct 30, 2024

#gogoeditdiff

Copy link

Here's a diff of how these changes impact the classified ontology (on -simple file):

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-30/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-master.owl/cl-simple.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-simple.owl
  • Version IRI: http://purl.obolibrary.org/obo/cl/releases/2024-10-30/cl-simple.owl
  • Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-simple-pr.owl/cl-simple.owl

Ontology imports

Ontology annotations

acinar cell of sebaceous gland http://purl.obolibrary.org/obo/CL_0002140

Removed

Added

Copy link

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

  • Ontology IRI: http://purl.obolibrary.org/obo/cl.owl
  • Version IRI: None
  • Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

acinar cell of sebaceous gland http://purl.obolibrary.org/obo/CL_0002140

Removed

Added

…gland-is-classified-under-epithelial-cell-of-sweat-gland
@dosumis
Copy link
Contributor

dosumis commented Oct 31, 2024

Looks like link to sebum secretion is lost. Ideally we'd have a link to a GO sebum secretion term. In the absence of that we may need to manually classify under sebum secreting cell.

@Caroline-99
Copy link
Collaborator Author

Looks like link to sebum secretion is lost. Ideally we'd have a link to a GO sebum secretion term. In the absence of that we may need to manually classify under sebum secreting cell.

I agree. It is currently manually classified under sebum secreting cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logical def] acinar cell of sebaceous gland is classified under epithelial cell of sweat gland
2 participants